Skip to content

Conversation

@wuzhuanhong
Copy link
Contributor

What this PR does / why we need it:

Add a new data source(huaweicloud_workspace_app_original_policy) to query the original policy of the Workspace APP.

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

add a new data source.

PR Checklist

  • Tests added/passed.
./scripts/coverage.sh -o workspace -f TestAccDataAppOriginalPolicy_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataAppOriginalPolicy_basic -timeout 360m -parallel 10
=== RUN   TestAccDataAppOriginalPolicy_basic
=== PAUSE TestAccDataAppOriginalPolicy_basic
=== CONT  TestAccDataAppOriginalPolicy_basic
--- PASS: TestAccDataAppOriginalPolicy_basic (18.61s)
PASS
coverage: 3.0% of statements in ./huaweicloud/services/workspace
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 19.330s coverage: 3.0% of statements in ./huaweicloud/services/workspace
  • Documentation updated.

  • Schema updated.

  • CheckDeleted.

    • a. During query operation (Read Context)
      aa. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

    • b. During delete/disassociate/unbind operation (Delete Context)
      ba. Resource not found
      >>>>>> Paste the screenshot here <<<<<<

@ruwenqiang123
Copy link
Contributor

LGTM

@wuzhuanhong wuzhuanhong force-pushed the data_wks_original_policy branch from 316e8ff to ea90cfb Compare December 2, 2025 08:45
@wuzhuanhong
Copy link
Contributor Author

./scripts/coverage.sh -o workspace -f TestAccDataAppOriginalPolicy_basic
Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDataAppOriginalPolicy_basic -timeout 360m -parallel 10
=== RUN TestAccDataAppOriginalPolicy_basic
=== PAUSE TestAccDataAppOriginalPolicy_basic
=== CONT TestAccDataAppOriginalPolicy_basic
--- PASS: TestAccDataAppOriginalPolicy_basic (12.26s)
PASS
coverage: 2.9% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 13.612s coverage: 2.9% of statements in ./huaweicloud/services/workspace

@wuzhuanhong wuzhuanhong force-pushed the data_wks_original_policy branch from ea90cfb to cec5358 Compare December 3, 2025 01:18
@Alice1319
Copy link

LGTM

@Lance52259
Copy link
Contributor

/approve
/lgtm

@github-ci-robot github-ci-robot added LGTM /lgtm approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 3, 2025
Copy link
Collaborator

@github-ci-robot github-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has been approved by: @Lance52259

/approve
/lgtm

@github-ci-robot github-ci-robot merged commit 5c31d43 into huaweicloud:master Dec 3, 2025
12 checks passed
@wuzhuanhong wuzhuanhong deleted the data_wks_original_policy branch December 4, 2025 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. feature LGTM /lgtm size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants