feat(workspace): add new resource for batch modify volume QoS #8418

946596029 · 2025-11-25T09:02:24Z

What this PR does / why we need it:
feat(workspace): add new resource for batch modify volume QOS

Which issue this PR fixes:
nothing

Special notes for your reviewer:
nothing

Release note:

1. add provider implement
2. add test case
3. add document

PR Checklist

Tests added/passed.

Documentation updated.
Schema updated.
CheckDeleted.

946596029 · 2025-12-05T10:18:06Z

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDesktop_basic -timeout 360m -parallel 10
=== RUN TestAccDesktop_basic
--- PASS: TestAccDesktop_basic (1097.24s)
PASS
coverage: 7.9% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 1097.394s coverage: 7.9% of statements in ./huaweicloud/services/workspace

946596029 · 2025-12-05T10:36:57Z

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDesktop_UpdateWithEpsId -timeout 360m -parallel 10
=== RUN TestAccDesktop_UpdateWithEpsId
--- PASS: TestAccDesktop_UpdateWithEpsId (665.23s)
PASS
coverage: 6.6% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 665.371s coverage: 6.6% of statements in ./huaweicloud/services/workspace

946596029 · 2025-12-05T11:57:18Z

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDesktop_powerAction -timeout 360m -parallel 10
=== RUN TestAccDesktop_powerAction
--- PASS: TestAccDesktop_powerAction (1371.03s)
PASS
coverage: 6.9% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 1371.157s coverage: 6.9% of statements in ./huaweicloud/services/workspace

946596029 · 2025-12-07T10:40:25Z

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDesktop_rootVolumeModify -timeout 360m -parallel 10
=== RUN TestAccDesktop_rootVolumeModify
--- PASS: TestAccDesktop_rootVolumeModify (913.02s)
PASS
coverage: 7.8% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 913.155s coverage: 7.8% of statements in ./huaweicloud/services/workspace

github-ci-robot · 2025-12-08T03:08:47Z

This PR needs rebase.

946596029 · 2025-12-08T03:22:00Z

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDesktop_dataVolumeModify -timeout 360m -parallel 10
=== RUN TestAccDesktop_dataVolumeModify
--- PASS: TestAccDesktop_dataVolumeModify (2085.28s)
PASS
coverage: 8.2% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 2085.432s coverage: 8.2% of statements in ./huaweicloud/services/workspace

946596029 · 2025-12-08T08:59:08Z

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDesktop_volumeChangeErrors -timeout 360m -parallel 10
=== RUN TestAccDesktop_volumeChangeErrors
--- PASS: TestAccDesktop_volumeChangeErrors (795.36s)
PASS
coverage: 7.7% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 795.528s coverage: 7.7% of statements in ./huaweicloud/services/workspace

946596029 · 2025-12-08T12:49:54Z

Prepare to calculate the coverage the following command:
TF_ACC=1 go test "./huaweicloud/services/acceptance/workspace" -v -coverprofile="./huaweicloud/services/acceptance/workspace/workspace_coverage.cov" -coverpkg="./huaweicloud/services/workspace" -run TestAccDesktop_volumeChangeErrors -timeout 360m -parallel 10
=== RUN TestAccDesktop_volumeChangeErrors
--- PASS: TestAccDesktop_volumeChangeErrors (819.53s)
PASS
coverage: 7.6% of statements in ./huaweicloud/services/workspace
ok github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud/services/acceptance/workspace 819.779s coverage: 7.6% of statements in ./huaweicloud/services/workspace

docs/resources/workspace_desktop.md

huaweicloud/services/workspace/resource_huaweicloud_workspace_desktop.go

huaweicloud/services/acceptance/workspace/data_source_huaweicloud_workspace_desktops_test.go

huaweicloud/services/workspace/resource_huaweicloud_workspace_desktop.go

Lance52259 · 2025-12-09T01:50:31Z

/approve

github-ci-robot

This PR has been approved by: @Lance52259

/approve

- change implement for modify volume QoS - add test case for volume normal change - add test case for volume abnormal change

Lance52259 · 2025-12-09T01:58:26Z

/lgtm

github-actions bot added feature size/L labels Nov 25, 2025

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch 5 times, most recently from 870546e to 71404f1 Compare November 28, 2025 03:48

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch from 71404f1 to 9c41dd3 Compare December 2, 2025 09:36

github-actions bot added the size/XL label Dec 2, 2025

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch 2 times, most recently from 0c89b91 to d86cba4 Compare December 5, 2025 06:20

946596029 changed the title ~~feat(workspace): add new resource for batch modify volume QOS~~ feat(workspace): add new resource for batch modify volume QoS Dec 5, 2025

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch 2 times, most recently from b168f1c to 037e17e Compare December 5, 2025 09:00

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch from 037e17e to a56bc1c Compare December 8, 2025 02:00

github-ci-robot added the needs-rebase This branch has conflicts that must be resolved. label Dec 8, 2025

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch 2 times, most recently from a9be47d to 615276c Compare December 8, 2025 09:20

github-ci-robot removed the needs-rebase This branch has conflicts that must be resolved. label Dec 8, 2025

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch 3 times, most recently from 7ae22c4 to a78a3e9 Compare December 8, 2025 12:09

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch 3 times, most recently from 543f3bc to 5f4fc2b Compare December 9, 2025 01:21

Lance52259 reviewed Dec 9, 2025

View reviewed changes

docs/resources/workspace_desktop.md Outdated Show resolved Hide resolved

huaweicloud/services/workspace/resource_huaweicloud_workspace_desktop.go Outdated Show resolved Hide resolved

huaweicloud/services/workspace/resource_huaweicloud_workspace_desktop.go Outdated Show resolved Hide resolved

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch from 5f4fc2b to 594c40d Compare December 9, 2025 01:28

Lance52259 reviewed Dec 9, 2025

View reviewed changes

huaweicloud/services/acceptance/workspace/data_source_huaweicloud_workspace_desktops_test.go Show resolved Hide resolved

huaweicloud/services/workspace/resource_huaweicloud_workspace_desktop.go Outdated Show resolved Hide resolved

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch from 594c40d to 161d109 Compare December 9, 2025 01:48

github-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025

github-ci-robot approved these changes Dec 9, 2025

View reviewed changes

feat(workspace): update desktop resource for batch modify volume QoS

0dbbe23

- change implement for modify volume QoS - add test case for volume normal change - add test case for volume abnormal change

946596029 force-pushed the br_workspace_batch_modify_volume_qos branch from 161d109 to 0dbbe23 Compare December 9, 2025 01:51

github-ci-robot added the LGTM /lgtm label Dec 9, 2025

github-ci-robot merged commit 364c955 into huaweicloud:master Dec 9, 2025
12 checks passed

feat(workspace): add new resource for batch modify volume QoS #8418

feat(workspace): add new resource for batch modify volume QoS #8418

Uh oh!

Conversation

946596029 commented Nov 25, 2025

PR Checklist

Uh oh!

946596029 commented Dec 5, 2025

Uh oh!

946596029 commented Dec 5, 2025

Uh oh!

946596029 commented Dec 5, 2025

Uh oh!

946596029 commented Dec 7, 2025

Uh oh!

github-ci-robot commented Dec 8, 2025

Uh oh!

946596029 commented Dec 8, 2025

Uh oh!

946596029 commented Dec 8, 2025

Uh oh!

946596029 commented Dec 8, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lance52259 commented Dec 9, 2025

Uh oh!

github-ci-robot left a comment

Choose a reason for hiding this comment

Uh oh!

Lance52259 commented Dec 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants