Enhance view state management by integrating UiStore for scroll position and selected event persistence #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…ion and selected event persistence addresses httptoolkit/httptoolkit#470 and further adds selected event persistence
pimterry
reviewed
Jun 19, 2025
There was a problem hiding this comment.
Thanks for the contribution @metheos! At a glance it looks like this is very promising, this is a nice improvement I'd definitely like to include. It looks like something has autoformatted all the UI store code along the way though, which makes this impossible to review and would break git blame later on.
Can you undo that please, so only the actual changes for this PR are included changes?
|
Should be good now. Missed that when I was testing. Changes were pretty minimal there! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses httptoolkit/httptoolkit#470 and further adds selected event persistence