chore(deps): replace deprecated har-validator - #28
Closed
alexandroit wants to merge 1 commit into
Closed
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Member
|
I'd rather not, sorry. Apart from the deprecation warning har-validator works fine, and shifting from a heavily used mature package to a brand new one creates more risk & hassle than upside. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTTPSnippetcurrently validates each input throughrequire('har-validator/lib/async'), while the upstream npm package isdeprecated as unsupported.
This changes only the dependency resolution:
The legacy package name and existing source import remain unchanged. The exact
version pin also keeps the migration deterministic.
Because
HTTPSnippetprepares requests immediately after the validatorcallback, I separately verified that the replacement preserves synchronous,
exactly-once callback behavior across every request fixture and a 1,000-call
stress run.
Verification
npm cinpm test: 1,667 passing; existing skipped tests unchangednpm run pretest: Standard and Echint passnpm pack --dry-runconversion, Promise validation, and invalid
HARErrorbehaviornpm audit --omit=dev: zero vulnerabilitiesDisclosure
I maintain
@stackline/har-validator, the replacement proposed here. It is anindependent MIT-licensed compatibility continuation and is not affiliated with
or endorsed by the original
har-validatormaintainers.Package: https://www.npmjs.com/package/@stackline/har-validator
Source: https://github.com/alexandroit/stackline-har-validator