Skip to content

add rfc template #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2019
Merged

add rfc template #191

merged 1 commit into from
May 5, 2019

Conversation

yoshuawuyts
Copy link
Member

Description

This adds an RFC template to Tide, similar to rustwasm's RFC template.

Motivation and Context

When making changes to an API it can be useful to get consensus on the design first in a structured manner before moving to implementation. The Rust project has proven that filing RFCs has been a a good strategy to discuss these kinds of changes, and we're seeing a similar process work well for rustwasm/gloo and crossbeam.

I've chosen to add the RFC template directly to Tide so we can discuss changes in the same repo. Having a separate RFC directory could be another option, but I feel that could be something we can move to at a later stage if we think that's desirable. The main goal for now is to provide us with a more structured way of proposing API changes, for which this should be the right way to go.

How Has This Been Tested?

No tests needed.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Yoshua Wuyts <[email protected]>
@xenith
Copy link
Contributor

xenith commented May 5, 2019

This has received no objections since being raised, going to go ahead and merge so we can build on top of it.

@xenith xenith merged commit 1f9e27b into master May 5, 2019
@delete-merged-branch delete-merged-branch bot deleted the rfc-template branch May 5, 2019 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants