No Clone for HttpClient-s #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fishrock123
added a commit
to Fishrock123/surf
that referenced
this pull request
Sep 24, 2020
Fishrock123
force-pushed
the
no-clone
branch
from
d650c19 to
868ffd2
Compare
Fishrock123
force-pushed
the
no-clone
branch
from
868ffd2 to
f2f5487
Compare
Fishrock123
added a commit
to Fishrock123/surf
that referenced
this pull request
Sep 24, 2020
All of the global shared client now uses just one Arc. Refs: http-rs/http-client#48
Fishrock123
added a commit
to Fishrock123/http-client
that referenced
this pull request
Sep 24, 2020
yoshuawuyts
approved these changes
Sep 25, 2020
Prevents users from writing `HttpClient {}`.
Fishrock123
force-pushed
the
no-clone
branch
from
f2f5487 to
d9d7e33
Compare
Fishrock123
added a commit
to Fishrock123/http-client
that referenced
this pull request
Sep 25, 2020
Fishrock123
added a commit
to Fishrock123/surf
that referenced
this pull request
Sep 25, 2020
All of the global shared client now uses just one Arc. Refs: http-rs/http-client#48
Fishrock123
added a commit
to Fishrock123/surf
that referenced
this pull request
Sep 25, 2020
All of the global shared client now uses just one Arc. Refs: http-rs/http-client#48
Fishrock123
added a commit
to Fishrock123/http-client
that referenced
this pull request
Jul 5, 2021
Kinda reverts http-rs#48 Related to http-rs/surf#237 Desirable for Surf-level config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Based on #45 for future simplicity.)An alternate to #47 "src: require Clone for HttpClient", this PR removes
Cloneimpls from allHttpClients.This is an alternate to the bottom part of http-rs/surf#237 / #46
The idea is to avoid multiple
Arcs, and this pushes the responsibility for sharing a client to the upper client, i.e. Surf. Surf already has to have a pointer for every client anyways, so as to hide the generic from itsClientdefinition.