do not send body content in reply to HEAD requests #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshuawuyts
approved these changes
Jun 30, 2020
Comment on lines
+183
to
+185
| // If we are responding to a HEAD request, we MUST NOT send | ||
| // body content | ||
| self.dispatch(State::End, cx, buf) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs http-rs/tide#623, closes #125
HTTP HEAD responses MUST NOT include response body content, but async-h1 does not currently support the ability to omit the response body and still send a content-length header.
Attempts to close this at the http-types layer left async-h1 hanging indefinitely because async-h1 uses the same notion of body length for the header and the actual response body sending. In order to address this at the async-h1 level, the encoder needs to know the request method. No public API as of this commit is changed by this spec-conformance bugfix.