Skip to content

Conversation

jcrugzz
Copy link
Contributor

@jcrugzz jcrugzz commented Feb 10, 2016

So the caveat here is that this is a breaking change, but i think it provides more useful context to the error as the error should be the actual proxyReq and not the req itself. In most cases (or at least using the callback api, you already have access to req and res so providing these ends up being useless. We were also previously capturing errors from client requests which I believe was creating false positives for people.

Thoughts @donasaur @indexzero

@donasaur
Copy link
Contributor

Yea, that's more helpful. I think if you also update the README for event listening, then it'll be fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants