Skip to content

Fix python implementation marker for setuptools 2.20 #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2016

Conversation

paradoxxxzero
Copy link
Contributor

Otherwise setup.py fail with error in html5lib setup command: Invalid environment marker: python_implementation == 'CPython'

@codecov-io
Copy link

Current coverage is 88.26%

Branch #227 has no coverage reports uploaded yet.

No diff could be generated. No reports for master found.

Powered by Codecov. Updated on successful CI builds.

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/6233

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

@gsnedders
Copy link
Member

Bah, Travis failing because of pip dropping 3.2 support. On the upside, easy to fix: we drop 3.2 support.

@gsnedders
Copy link
Member

@paradoxxxzero Sorry for the delay; can you rebase this on master?

@paradoxxxzero
Copy link
Contributor Author

Done sorry for the delay :)

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 5dac3ac on paradoxxxzero:master into 4205423 on html5lib:master.

@gsnedders gsnedders merged commit d999875 into html5lib:master Mar 24, 2016
@Chronial
Copy link

This breaks setup on older setuptools (this is my system setuptools):

> python setup.py sdist
error in html5lib setup command: Invalid environment marker: platform_python_implementation == 'CPython'
> python --version
Python 2.7.6
> easy_install --version
setuptools 3.3
> cat /etc/issue
Ubuntu 14.04.3 LTS \n \l

@gsnedders
Copy link
Member

@Chronial see #231 for dealing with that; I presume in the future we'll break a relatively small number of setuptools releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants