Skip to content

Don't block on tail.Lines on shutdown #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't block on tail.Lines on shutdown #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tail.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,8 @@ func (tail *Tail) tailFileSync() {
// file when rate limit is reached.
msg := ("Too much log activity; waiting a second " +
"before resuming tailing")
tail.Lines <- &Line{msg, time.Now(), errors.New(msg)}
select {
case tail.Lines <- &Line{msg, time.Now(), errors.New(msg)}:
case <-time.After(time.Second):
case <-tail.Dying():
return
Expand Down Expand Up @@ -414,7 +414,11 @@ func (tail *Tail) sendLine(line string) bool {
}

for _, line := range lines {
tail.Lines <- &Line{line, now, nil}
select {
case tail.Lines <- &Line{line, now, nil}:
case <-tail.Dying():
return false
}
}

if tail.Config.RateLimiter != nil {
Expand Down