-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not-so-pretty fix for logical numbering output. Needs improvement #307
Not-so-pretty fix for logical numbering output. Needs improvement #307
Conversation
a9680e7
to
8a5f8bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @GuillaumeMercier.
I'm a little worried about the length of the logical listing. For example, I see the following while running test-process-scopes
:
Current cpubind is 0-5 | cpubind (logical)=[0,1,2,3,4,5]
On my machine the string isn't excessively long, but I fear for high core count machines the logical list will be. How much of a pain would it be for the logical and physical outputs to be the same format? For example,
Current cpubind is 0-5 | cpubind (logical)=0-5
Will the logical output change to a bitmap listing when we ask for the bitmap format?
a1f4dca
to
30b6058
Compare
@samuelkgutierrez : I took a look at the code in hwloc and it seemed rather painful to get the result you want (and that I'd like to have too). But I think that I'll give it a shot. meanwhile, I pushed another version where I compute the strings lengths so that there won't be any size issue w.r.t this matter. |
No, right now, it's the same output. I don't think that it would make any sense to have a bitmap format for logical indices anyway. |
e1cc7e4
to
4a824da
Compare
Signed-off-by: Guillaume Mercier <[email protected]>
4a824da
to
a65a6de
Compare
Done.
I discussed about this with Brice and we agreed that it would be very confusing and it should be avoided. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @GuillaumeMercier.
Fixes #286. |
No description provided.