Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not-so-pretty fix for logical numbering output. Needs improvement #307

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

GuillaumeMercier
Copy link
Collaborator

No description provided.

Copy link
Member

@samuelkgutierrez samuelkgutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @GuillaumeMercier.

I'm a little worried about the length of the logical listing. For example, I see the following while running test-process-scopes:

Current cpubind is 0-5 | cpubind (logical)=[0,1,2,3,4,5]

On my machine the string isn't excessively long, but I fear for high core count machines the logical list will be. How much of a pain would it be for the logical and physical outputs to be the same format? For example,

Current cpubind is 0-5 | cpubind (logical)=0-5

Will the logical output change to a bitmap listing when we ask for the bitmap format?

@GuillaumeMercier GuillaumeMercier force-pushed the logical-output-fix branch 2 times, most recently from a1f4dca to 30b6058 Compare February 12, 2025 16:33
@GuillaumeMercier
Copy link
Collaborator Author

@samuelkgutierrez : I took a look at the code in hwloc and it seemed rather painful to get the result you want (and that I'd like to have too). But I think that I'll give it a shot. meanwhile, I pushed another version where I compute the strings lengths so that there won't be any size issue w.r.t this matter.

@GuillaumeMercier
Copy link
Collaborator Author

GuillaumeMercier commented Feb 12, 2025

Will the logical output change to a bitmap listing when we ask for the bitmap format?

No, right now, it's the same output. I don't think that it would make any sense to have a bitmap format for logical indices anyway.
BTW, it would be nice to have the same compilation flags between the git repo and the CI here. My code compiles just fine on my system but fails failed here because there are issues trigered by the flag -Werror=stringop-overflow=.

@GuillaumeMercier GuillaumeMercier force-pushed the logical-output-fix branch 2 times, most recently from e1cc7e4 to 4a824da Compare February 14, 2025 09:29
Signed-off-by: Guillaume Mercier <[email protected]>
@GuillaumeMercier
Copy link
Collaborator Author

On my machine the string isn't excessively long, but I fear for high core count machines the logical list will be. How much of a pain would it be for the logical and physical outputs to be the same format?

Done.

Will the logical output change to a bitmap listing when we ask for the bitmap format?

I discussed about this with Brice and we agreed that it would be very confusing and it should be avoided.

Copy link
Member

@samuelkgutierrez samuelkgutierrez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @GuillaumeMercier.

@samuelkgutierrez samuelkgutierrez merged commit 845ae99 into hpc:master Feb 14, 2025
3 checks passed
@samuelkgutierrez
Copy link
Member

Fixes #286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants