Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qv_thread_scope_split_* first implementation #178

Merged

Conversation

GuillaumeMercier
Copy link
Collaborator

First draft of implementation for qv_thread_scope_split_*.

Several questions/issues to discuss:

  1. both routines do not use the context parameter? Is this an error on my side or should the interface be modified?
  2. I question the behavior of the qv_thread_scope_split routine. This version is passing my simple test but I'm unsure that the result is what we want to achieve. To be discussed.
  3. The thread bug with two threads being mapped to the same resources has still to be addressed.

@samuelkgutierrez samuelkgutierrez merged commit 4a0991e into hpc:thread-bug-work Jun 25, 2024
@samuelkgutierrez
Copy link
Member

Thank you, @GuillaumeMercier! I'll take a closer look at this and merge into master when appropriate. We will address the issues you bring up.

@GuillaumeMercier
Copy link
Collaborator Author

It isn't much, but allows us to further make tests. We'll discuss this next week if possible. I'll try to improve things until then.

@samuelkgutierrez
Copy link
Member

Looking good so far. I'm going to bring these changes into master soon. Once I've done that, please continue your work off of master to avoid diverging too much. Thank you.

@GuillaumeMercier
Copy link
Collaborator Author

I'll get rid of the thread-bug-work branch and create a new one from master to continue the work.

@GuillaumeMercier
Copy link
Collaborator Author

Btw, the function names have not been thoroughly thought. Change what you dislike.

@samuelkgutierrez
Copy link
Member

@GuillaumeMercier #179 is in. You can start working off master now.

@GuillaumeMercier GuillaumeMercier deleted the thread-bug-work branch June 26, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants