Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: DPL: remove no-restart option #1775

Merged

Conversation

AndreasBoehm
Copy link
Member

To ensure that inverters connected to batteries and smart-buffers work fine they need to be restarted regularly, with this change we remove the option to disable that behaviour, which was the default in the UI and in the configuration.

Copy link
Member

@schlimmchen schlimmchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic seems fine, the texts are in need of refinement.

@@ -736,8 +736,7 @@
"VoltageThresholds": "Batterie Spannungs-Schwellwerte ",
"VoltageLoadCorrectionInfo": "<b>Hinweis:</b> Wenn Leistung von der Batterie abgegeben wird, bricht ihre Spannung etwas ein. Der Spannungseinbruch skaliert mit dem Entladestrom. Damit Wechselrichter nicht vorzeitig ausgeschaltet werden sobald der Stop-Schwellenwert unterschritten wurde, wird der hier angegebene Korrekturfaktor mit einberechnet, um die Spannung zu errechnen, die der Akku in Ruhe hätte. Korrigierte Spannung = DC Spannung + (Aktuelle Leistung (W) * Korrekturfaktor).",
"InverterRestartHour": "Uhrzeit für automatischen Wechselrichterneustart",
"InverterRestartDisabled": "Keinen automatischen Neustart planen",
"InverterRestartHint": "Der Tagesertrag des Wechselrichters wird beim Einsatz an Solarmodulen nachts zurückgesetzt, wenn sich der Wechselrichter mangels Licht abschaltet. Um den Tageserstrag zurückzusetzen obwohl der Wechselrichter dauerhaft von einer Batterie gespeist wird, kann der Inverter täglich zur gewünschten Uhrzeit automatisch neu gestartet werden."
"InverterRestartHint": "Der Wechselrichter wird täglich zur gewünschten Zeit automatisch neu gestartet. Dies ist notwendig, da sich die Wechselrichter seltsam verhalten, wenn sie nicht neu gestartet oder längere Zeit (Tage/Wochen/Monate) ohne Strom sind, und um den täglichen Ertrag zurückzusetzen."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"da sich die Wechselrichter seltsam verhalten" => "da sich die Wechselrichter möglicherweise unerwartet verhalten"
ohne Strom? => "längere Zeit (Tage/Wochen/Monate) am Stück in Betrieb sind"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Viel besser! Danke

@@ -739,8 +739,7 @@
"VoltageThresholds": "Battery Voltage Thresholds",
"VoltageLoadCorrectionInfo": "<b>Hint:</b> When the battery is discharged, its voltage drops. The voltage drop scales with the discharge current. In order to not stop inverters too early (stop threshold), this load correction factor can be specified to calculate the battery voltage if it was idle. Corrected voltage = DC Voltage + (Current power * correction factor).",
"InverterRestartHour": "Automatic Inverter Restart Time",
"InverterRestartDisabled": "Do not execute automatic restart",
"InverterRestartHint": "When used with solar modules, the inverter's daily yield is usually reset at night when the inverter turns off due to lack of light. To reset the daily yield even though the inverter is continuously powered by a battery, the inverter can be automatically restarted daily at the desired time."
"InverterRestartHint": "The inverter(s) will be automatically restarted daily at the desired time. This is necessary because the inverter(s( behave strangely if not restarted or without power for days/weeks/months and to reset the daily yield."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not keep untranslated tokens in locales. Remove this. The English token will be used as fallback gracefully anyways.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Point!

@@ -738,8 +738,7 @@
"VoltageThresholds": "Battery Voltage Thresholds",
"VoltageLoadCorrectionInfo": "<b>Hint:</b> When the battery is discharged, its voltage drops. The voltage drop scales with the discharge current. In order to not stop inverters too early (stop threshold), this load correction factor can be specified to calculate the battery voltage if it was idle. Corrected voltage = DC Voltage + (Current power * correction factor).",
"InverterRestartHour": "Automatic Inverter Restart Time",
"InverterRestartDisabled": "Do not execute automatic restart",
"InverterRestartHint": "When used with solar modules, the inverter's daily yield is usually reset at night when the inverter turns off due to lack of light. To reset the daily yield even though the inverter is continuously powered by a battery, the inverter can be automatically restarted daily at the desired time."
"InverterRestartHint": "The inverter(s) will be automatically restarted daily at the desired time. This is necessary because the inverter(s( behave strangely if not restarted or without power for days/weeks/months and to reset the daily yield."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This is necessary because the inverter(s( behave strangely if not restarted or without power for days/weeks/months and to reset the daily yield." => "This is necessary because the inverter may behave unexpectedly if not restarted and powered continuously for days/weeks/months. A restart is also required to reset the daily yield."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! thanks

To ensure that inverters connected to batteries and smart-buffers work fine they need to be restarted regularly, with this change we remove the option to disable that behaviour, which was the default in the UI and in the configuration.
@AndreasBoehm AndreasBoehm force-pushed the andreasboehm/chore/remove-no-restart-option branch from d2b9b08 to ebadabd Compare March 25, 2025 19:26
@schlimmchen schlimmchen merged commit 6fb8618 into development Mar 25, 2025
16 checks passed
@schlimmchen schlimmchen deleted the andreasboehm/chore/remove-no-restart-option branch March 25, 2025 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants