-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wildcard version matching endpoint #11
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions in their names
hown3d
requested changes
Oct 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, I have some suggestions.
Remove second loop through apkPackages
hown3d
reviewed
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a
/wildcardVersion/<PACKAGE_WITH_WILDCARD_VERSION>
Endpoint to match against packages with versions in their names.The Wolfi APK-Index recently started to incorporate a lot more versioned releases which renovate can't check against. So the solution is to extend the renovate-apk-indexer to consider wildcard matches for these packages. Example as provided in the Readme:
E.g. These are all valid package names in the wolfi APK index. Note that the base name without the number does not necessarily contain the most recent version:
To use the wildcard version endpoint, you can provide a single '*' at the point where the renovate-apk-indexer should expect a version number. Be aware that this will skip the base-package-name if there is no suffix on the wildcard string. This is a technical limitation, see explaination at
/wildcardVersion/argo-cd*
/wildcardVersion/argo-cd*
argo-cd-<number>
, notargo-cd
orargo-cd-<number>-compat
This is a technical limitation to prevent the regex to match argo-cd-compat. If the suffix of the wildcard is empty it won't consider "non-number" matches for the suffix/wildcardVersion/argo-cd*compat
argo-cd-<number>-compat
and argo-cd-compat/wildcardVersion/argo-cd-*-compat
argo-cd-<number>-compat
and argo-cd-compat/wildcardVersion/nodejs*
nodejs-<number>
, notnodejs
. This is a technical limitation, see explaination of/wildcardVersion/argo-cd*