Skip to content

🔪 Remove unnused chalk dependency #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2021
Merged

Conversation

jrolfs
Copy link
Collaborator

@jrolfs jrolfs commented Feb 8, 2021

No description provided.

@jrolfs jrolfs self-assigned this Feb 8, 2021
@jrolfs jrolfs requested review from aarosil and nickcobbett February 8, 2021 22:15
@nickcobbett
Copy link

no yarn.lock changes?

@jrolfs jrolfs added the automerge dd this label to any PRs that you want merged as soon as CI passes label Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #336 (0190fee) into main (0eba16c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files          25       25           
  Lines         291      291           
  Branches       59       59           
=======================================
  Hits          271      271           
  Misses         19       19           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eba16c...0190fee. Read the comment docs.

@github-actions github-actions bot force-pushed the fix/remove-chalk branch 3 times, most recently from 5615f63 to 1e713a6 Compare February 8, 2021 22:25
@jrolfs
Copy link
Collaborator Author

jrolfs commented Mar 2, 2021

@dependabot recreate

@jrolfs
Copy link
Collaborator Author

jrolfs commented Mar 2, 2021

@nickcobbett I think we still depend on chalk transitively (a dependency of a dependency) which would explain the lockfile not changing? I also noticed this when I made the change.

@jrolfs jrolfs force-pushed the fix/remove-chalk branch from df2a325 to d7afb03 Compare March 3, 2021 21:12
@jrolfs jrolfs force-pushed the fix/remove-chalk branch from d7afb03 to 0190fee Compare March 3, 2021 21:13
@github-actions github-actions bot merged commit a38bccd into main Mar 3, 2021
@github-actions github-actions bot deleted the fix/remove-chalk branch March 3, 2021 21:16
@github-actions github-actions bot removed the automerge dd this label to any PRs that you want merged as soon as CI passes label Mar 3, 2021
@jrolfs
Copy link
Collaborator Author

jrolfs commented Mar 3, 2021

🎉 This PR is included in version 5.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jrolfs jrolfs added the released label Mar 3, 2021
@jrolfs jrolfs restored the fix/remove-chalk branch March 3, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants