Fix commit script #161
Merged
Fix commit script #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason invoking this script with `yarn commit` now passes through `'commit'` in the arguments that get parsed as "raw git arguments" in the adapter which blows up said parsing behavior. I'm not sure if this was related to a yarn change (`yarn [script] args` vs. `yarn [script] -- args`) or something else... Either way, this is a band-aid to filter out the rogue argument for now.
Use `require.resolve` to resolve 'commitizen' path for use in `bootstrap`ing prompt adapter to make resolution more resilient and remove the dependency on `node_modules` directory.
Collaborator
Author
|
✅ tests via |
Collaborator
Author
|
🎉 This PR is included in version 4.5.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Put band-aid in place for bug that cropped up when invoking
hover-scripts commitfromyarn commitAdditional
Also use
require.resolveto resolve 'commitizen' path for use inbootstraping prompt adapter to make resolution more resilient and remove the dependency onnode_modulesdirectory.