Drop Support for [email protected]
#698
Merged
+21
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanpdoyle
force-pushed
the
drop-support-for-ruby-2
branch
5 times, most recently
from
1035891 to
600f23f
Compare
seanpdoyle
force-pushed
the
drop-support-for-ruby-2
branch
3 times, most recently
from
251dbbc to
e7a8848
Compare
Commit to requiring `[email protected]` Remove `[email protected]`, `[email protected]`, `[email protected]`, `[email protected]`, and `[email protected]` from the CI matrix, along with any `RUBY_VERSION < "3"` conditionals. The implementation changes include replace older syntaxes with newer variants. For example, utilize `...` in place of `*args, &block`, rely on `**`-ing attribute `Hash` arguments, etc.
seanpdoyle
force-pushed
the
drop-support-for-ruby-2
branch
from
e7a8848 to
79f7cce
Compare
|
@jorgemanrubia I've rebased off Does this changeset achieve the same outcome as https://github.com/hotwired/turbo-rails/tree/fix-tests? If not, maybe you can cherry-pick the changes necessary to pass CI. |
|
Lovely, thanks @seanpdoyle! I had started to look into fixing the tests, I didn't realize you had this one open 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #681
Follow-up to #682
Commit to requiring
[email protected]Remove
[email protected],[email protected],[email protected],[email protected], and[email protected]from the CI matrix, along with anyRUBY_VERSION < "3"conditionals.The implementation changes include replace older syntaxes with newer variants. For example, utilize
...in place of*args, &block, rely on**-ing attributeHasharguments, etc.