-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kafka version to include client side gzip leak fix #4
base: master
Are you sure you want to change the base?
Conversation
+CC @bikassaha @jerryshao |
Two tests failed again:
Is this a kafka incompatibility ? Or flakey tests ? |
We might hit this issue (https://issues.apache.org/jira/browse/SPARK-18057?focusedCommentId=15905716&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-15905716) in the test code. |
Looks like it is not a straightforward case of upgrading dependency. |
If we ignore the UT failure, then I think it is OK to upgrade the Kafka version. This is because test code uses several internal APIs which doesn't guarantee to be compatible across version, whereas source code only depends on kafka-client APIs, which guarantees to be compatible, so it is OK to upgrade the Kafka version if we ignore the UT failures. |
@jerryshao Ignoring UT failures, which used to work with earlier versions, is a bit worrying; we potentially miss out of issues (particularly when evolving code). |
This is the same pr which I submitted against @jerryshao's older repo.
I have also bumped up the artifact version due to dependency version change.