fix(watch): not_running is the new queued #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are seeing premature buildevents terminations because we see all jobs succeeded or failed, and ignore the not_running.
TylerHelmuth
added
the
status: oncall
Co-authored-by: Jamie Danielson <[email protected]>
|
For posterity, job status possible responses
|
JamieDanielson
added
type: bug
JamieDanielson
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
We are seeing premature buildevents terminations because we see all jobs succeeded or failed, and ignore the not_running.
Short description of the changes
Treat the new not_running status the same as "queued".
How to verify
https://app.circleci.com/pipelines/github/honeycombio/hound/80521/workflows/d0f8b476-2b41-4aeb-93b0-428c3c46ed9c/jobs/1341656?invite=true#step-102-5277_75 jobs like this should no longer show "succeeded" when there are still jobs left "not_running"
we should stop seeing async traces like https://ui-dogfood.honeycomb.io/prod/environments/prod/datasets/build-events/result/Hne5hzeBSEu/trace/bP2CUXc6L59?source=query&span=d0f8b476-2b41-4aeb-93b0-428c3c46ed9c