Skip to content

fix(links): change base for fragment resolution #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

fix(links): change base for fragment resolution #29

merged 1 commit into from
Apr 23, 2025

Conversation

Tieske
Copy link
Contributor

@Tieske Tieske commented Nov 19, 2024

fixes #28

@Thalhammer Thalhammer changed the title fix(links): change base fore fragment resolution fix(links): change base for fragment resolution Nov 21, 2024
@Thalhammer
Copy link
Member

Did you verify everything else still works ?
A very vaguely remember putting the explicit base tag there because something didn't resolve correctly without.

@davidgraeff
Copy link
Member

Currently links are indeed broken, let's remove setting the base, which usually complicates things anyway.

@davidgraeff davidgraeff merged commit 8c4d899 into master Apr 23, 2025
1 check passed
@Tieske Tieske deleted the Tieske-patch-1 branch April 23, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidgraeff davidgraeff davidgraeff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Links in the spec are broken
3 participants
@Tieske @Thalhammer @davidgraeff