-
Notifications
You must be signed in to change notification settings - Fork 22
feat: Support Zarr v3 (Replace zarr.js with zarrita.js) #172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @manzt, great to see zarrita in vizarr! |
Ah you are right. Fixed that, but now I'm seeing a CORs error can cant seem to request the |
Thanks! CORS shouldn't be an issue for https://static.webknossos.org/data/zarr_v3/l4_sample/color/1/zarr.json. It has
An individual zoom level should work, no? I am now running into an infinite loop when calling this URL: https://deploy-preview-172--vizarr.netlify.app/?source=https://static.webknossos.org/data/zarr_v3/l4_sample/color/1&viewState={%22zoom%22:null,%22target%22:[512,3200]} Fyi, I already changed the |
I believe so! Just wanted to clarify the multiscale 3d. |
Hmm sorry about that. Not sure what is going on. Still running into a CORs issue. Not sure what is going on: ![]() Fyi, I already changed the Ah, need to make the changes in zarrita. |
That might be related to running on localhost and/or with http. On netlify there is no CORS error. |
Sorry, haven't had the chance to look into this more closely! I'm getting a CORS issue, even with netlify (maybe it's my browsers?). |
I think I found the loop. I can now load some data! |
Awesome. Thanks for finding the bug!
Ah, I'm fairly certain this is coming from us using zarr chunk API directly (and some assumption about non x/y chunks being 1). #60 (comment). I probably won't be able to dig in for a couple of weeks, but a first thought would be that we could try to "rechunk" within the store to play nicer with Viv. |
https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/v0.5-dev2/6001240.zarr ? (from ome/ome-ngff-validator#36) |
I also tried creating a sharded example at https://deploy-preview-36--ome-ngff-validator.netlify.app/?source=https://minio-dev.openmicroscopy.org/idr/v0.5-dev2/6001240_sharded.zarr but that isn't yet being loaded successfully by zarrita.js in that validator branch (whereas the non-sharded v3 data that Josh linked to is loading fine). |
@manzt: is there anything that would help in the way of test data, etc.? |
I'm sorry I've been quiet on this... my talk at SciPy is today and then I'll be relaxed and excited to zarr after :) |
np. Knock 'em dead! 👊🏽 |
Co-authored-by: Norman Rzepka <[email protected]>
Did the multiscales metadata move under EDIT: Ahh, it looks like all the ome metadata is under |
I think I got this to a working state. I've been trying out with some sample images here, but I don't have many for v3. Would any of you be able to have a look? |
@normanrz I removed the zarrita -> zarr.js adapter stuff and now we have a pure zarrita pixel source for viv. This should allow better composition with the rest of zarrita and better footing ofr the future of vizarr. |
I'm running into some issue with the plates but once I get that resolved I'll merged and make a release (v0.4). |
I'll need to double check what got released, @manzt, but the much of the "0.5" data that is flying around right now is all |
Ok,then similarly i'll keep vizarr in a prerelease state. |
What URL should we use for that period? cf. ome/ome-ngff-validator@3a1ecfb |
So currently https://hms-dbmi.github.io/vizarr points to whatever is on |
Guess there's a 2 version number issue here. If |
Experiment to replace zarr.js with zarrita.js. Should support v3 data (including sharding, although I don't have any NGFF datasets to test).
Need to figure out how to handle loading v3 vs v2. Right now it will try v3 first and fallback to v2. Maybe another query parameter to indicate which?
cc: @normanrz