Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All dockable windows are tabs. Undocked create a window for further docking. #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexkoon
Copy link

Every window is now a tab on content pane for a consistent look in dock panes. An undocked pane creates its own window where further windows can be docked. Allows an app to have multiple windows across monitors for example. Empty windows cleaned up.

Bug fix for isTabbed in DockNode - not uses the TabbedProperty value.

…ck panes. An undocked pane creates its own window where further windows can be docked. Allows an app to have multiple windows across monitors for example. Empty windows cleaned up.

Bug fix for isTabbed in DockNode - not uses the TabbedProperty value.
@alexkoon
Copy link
Author

Hi - have you had a chance to look at this yet? Or any issues?

@hkmoon
Copy link
Owner

hkmoon commented Jan 17, 2017

Hi @alexkoon

First of all, I am sorry for my laziness due to current projects. I could not take a look on your code.
Today, I had a chance to do that actually.

However, many people are using https://github.com/ClearControl/DockFX instead of my repo because it is now community project. Perhaps, you could have a look the latest codes there and check if there is something wrong compared to your modified codes.

Thank you so much!

@jasons2000
Copy link

jasons2000 commented Jan 17, 2017 via email

@hkmoon
Copy link
Owner

hkmoon commented Jan 17, 2017

@jasons2000 Someone sounds pointing at me. ;)

@alexkoon
Copy link
Author

Thanks - I'll have a look over at the ClearControl branch.

@hkmoon
Copy link
Owner

hkmoon commented Jan 19, 2017

@alexkoon Sorry! I actually reverted whole merging process because github had some problems last week. I need more time to check it actually. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants