Csanád's review of chapter 25 #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xronophobe
commented
Apr 18, 2025
| @@ -953,6 +977,8 @@ $ *git push* | |||
| // so we can check it's working? (Partly it's because you're not so directive about where to put the fail so it | |||
| // feels more ephemeral.) | |||
|
|
|||
| // CSANAD: the official book-example also removed the `self.fail()` by this point. | |||
There was a problem hiding this comment.
This was an answer to David's comment
Xronophobe
commented
Apr 18, 2025
| // version does generate a screenshot for every FT, it isn't true for the Gitlab. | ||
| // However, there is another odd thing: I tried re-adding the `self.fail` | ||
| // which resulted in three screenshots on Gitlab: | ||
| // https://gitlab.com/csberes/superlistz-version-harry/-/jobs/9766298077 |
There was a problem hiding this comment.
Three screenshots, but only one failing test, which I made to fail.
add suggestion for GitLab instance recommendation
|
thanks very much for picking up on these issues Csanad much appreciated! will look into it... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very useful topic and I agree with the approach. However, I found some inconsistencies in the chapter. Unfortunately, I was unable to spend more time figuring it out, but I tried providing every clue I found relevant.
@hjwp if you need anything else regarding these, just let me know!
Apart from the possible bugs, I think this chapter shows and explains very well how to set up automated CI builds and how to troubleshoot them.