Conversation
Installing le locale instead of trying to convert to any possible locale
hjwp
reviewed
May 20, 2024
Comment on lines
+1
to
+9
| import unittest | ||
| from sourcetree import ( | ||
| SourceTree, | ||
| ) | ||
|
|
||
|
|
||
| class RequirementTestCase(unittest.TestCase): | ||
| def test_en_GB_locale_is_installed(self): | ||
| sourcetree = SourceTree() |
Owner
There was a problem hiding this comment.
we can use pytest for tests:
Suggested change
| import unittest | |
| from sourcetree import ( | |
| SourceTree, | |
| ) | |
| class RequirementTestCase(unittest.TestCase): | |
| def test_en_GB_locale_is_installed(self): | |
| sourcetree = SourceTree() | |
| from sourcetree import SourceTree | |
| def test_en_GB_locale_is_installed(self): | |
| sourcetree = SourceTree() |
hjwp
reviewed
May 20, 2024
|
|
||
| assert ( | ||
| "en_GB.utf8" in locales, | ||
| "Lacking en_GB locale. " "This interferes with checks for output.", |
Owner
There was a problem hiding this comment.
tbh even if you do have utf8 locale installed, the chapter 1 tests fail sometimes (eg on a mac). i think i added a workaround/hack for this somewhere...
Owner
|
gonna close this for now, have to focus on finalising a draft for print. feel free to reopen ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a missing locate warning interfering with process output expectations.