-
Notifications
You must be signed in to change notification settings - Fork 186
feat: Implement Crypto Transfer simple fees calculator #22192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement Crypto Transfer simple fees calculator #22192
Conversation
Signed-off-by: artemderevets <[email protected]>
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcher.java
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
hedera-node/hedera-app-spi/src/main/java/com/hedera/node/app/spi/fees/CalculatorState.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #22192 +/- ##
=========================================
Coverage 71.00% 71.00%
- Complexity 24755 24779 +24
=========================================
Files 2709 2710 +1
Lines 105698 105789 +91
Branches 11130 11158 +28
=========================================
+ Hits 75047 75120 +73
- Misses 26581 26592 +11
- Partials 4070 4077 +7
... and 16 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: artemderevets <[email protected]>
...hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcher.java
Outdated
Show resolved
Hide resolved
…anges) Signed-off-by: artemderevets <[email protected]>
…anges) Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
hedera-node/hapi-fees/src/test/resources/simple-fee-schedule.json
Outdated
Show resolved
Hide resolved
hedera-node/hapi-fees/src/test/resources/simple-fee-schedule.json
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/token/impl/calculator/CryptoTransferFeeCalculator.java
Outdated
Show resolved
Hide resolved
...clients/src/main/java/com/hedera/services/bdd/suites/fees/CryptoTransferSimpleFeesSuite.java
Outdated
Show resolved
Hide resolved
# Conflicts: # hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcher.java # hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcherTest.java # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
hapi/hedera-protobuf-java-api/src/main/proto/fees/fee_schedule.proto
Outdated
Show resolved
Hide resolved
hapi/hedera-protobuf-java-api/src/main/proto/fees/fee_schedule.proto
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/token/impl/calculator/CryptoTransferFeeCalculator.java
Outdated
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/token/impl/calculator/CryptoTransferFeeCalculator.java
Outdated
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/token/impl/calculator/CryptoTransferFeeCalculator.java
Outdated
Show resolved
Hide resolved
Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
joshmarinacci
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the merge conflict first.
# Conflicts: # hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
...main/java/com/hedera/node/app/service/token/impl/calculator/CryptoTransferFeeCalculator.java
Outdated
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/token/impl/calculator/CryptoTransferFeeCalculator.java
Outdated
Show resolved
Hide resolved
...main/java/com/hedera/node/app/service/token/impl/calculator/CryptoTransferFeeCalculator.java
Outdated
Show resolved
Hide resolved
hedera-node/hedera-file-service-impl/src/main/resources/genesis/simpleFeesSchedules.json
Outdated
Show resolved
Hide resolved
Neeharika-Sompalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @aderevets ! Overall LGTM, but there are some more comments I have which can be addressed in next PR.
Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
Neeharika-Sompalli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @aderevets
|
Merging this PR as all checks passed on the Mirror PR #22390 |
Signed-off-by: artemderevets <[email protected]> Signed-off-by: Petar Tonev <[email protected]>
Description:
Implement crypto transfer simple fees calculator.
Adjust simpleFeesSchedules.json
Added simple fees comparison HAPI test.
Related issue(s):
Fixes #20443
Notes for reviewer: