Skip to content

Conversation

@aderevets
Copy link
Contributor

@aderevets aderevets commented Nov 17, 2025

Description:
Implement crypto transfer simple fees calculator.
Adjust simpleFeesSchedules.json
Added simple fees comparison HAPI test.

Related issue(s):

Fixes #20443

Notes for reviewer:

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@aderevets aderevets requested review from a team as code owners November 17, 2025 15:46
@aderevets aderevets self-assigned this Nov 17, 2025
# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcher.java
@lfdt-bot
Copy link

lfdt-bot commented Nov 17, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 69.69697% with 30 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...n/impl/calculator/CryptoTransferFeeCalculator.java 69.07% 21 Missing and 9 partials ⚠️

Impacted file tree graph

@@            Coverage Diff            @@
##               main   #22192   +/-   ##
=========================================
  Coverage     71.00%   71.00%           
- Complexity    24755    24779   +24     
=========================================
  Files          2709     2710    +1     
  Lines        105698   105789   +91     
  Branches      11130    11158   +28     
=========================================
+ Hits          75047    75120   +73     
- Misses        26581    26592   +11     
- Partials       4070     4077    +7     
Files with missing lines Coverage Δ Complexity Δ
...pp/workflows/dispatcher/TransactionDispatcher.java 59.34% <ø> (ø) 43.00 <0.00> (ø)
.../node/app/service/token/impl/TokenServiceImpl.java 100.00% <ø> (ø) 4.00 <0.00> (ø)
...ken/impl/calculator/CryptoCreateFeeCalculator.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...ken/impl/calculator/CryptoUpdateFeeCalculator.java 100.00% <100.00%> (ø) 5.00 <0.00> (ø)
...n/impl/calculator/CryptoTransferFeeCalculator.java 69.07% <69.07%> (ø) 25.00 <25.00> (?)

... and 16 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
# Conflicts:
#	hedera-node/hedera-app/src/main/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcher.java
#	hedera-node/hedera-app/src/test/java/com/hedera/node/app/workflows/dispatcher/TransactionDispatcherTest.java
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
@aderevets aderevets requested a review from a team as a code owner November 24, 2025 15:32
joshmarinacci
joshmarinacci previously approved these changes Dec 2, 2025
Copy link
Contributor

@joshmarinacci joshmarinacci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the merge conflict first.

# Conflicts:
#	hedera-node/hedera-token-service-impl/src/main/java/com/hedera/node/app/service/token/impl/TokenServiceImpl.java
@codacy-production
Copy link

codacy-production bot commented Dec 3, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 82.98%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (86993ad) 105601 79071 74.88%
Head commit (3a85fb1) 105687 (+86) 79151 (+80) 74.89% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#22192) 94 78 82.98%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @aderevets ! Overall LGTM, but there are some more comments I have which can be addressed in next PR.

Signed-off-by: artemderevets <[email protected]>
Signed-off-by: artemderevets <[email protected]>
Copy link
Contributor

@Neeharika-Sompalli Neeharika-Sompalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @aderevets

@andrewb1269
Copy link
Contributor

Merging this PR as all checks passed on the Mirror PR #22390

@andrewb1269 andrewb1269 merged commit 4747093 into hiero-ledger:main Dec 3, 2025
29 of 32 checks passed
petreze pushed a commit that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crypto Service support

6 participants