-
Notifications
You must be signed in to change notification settings - Fork 184
chore: Add FATAL log validation in HgcaaLogValidator
#22178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Neeharika-Sompalli <[email protected]>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
tinker-michaelj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tyvm @Neeharika-Sompalli !
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #22178 +/- ##
============================================
- Coverage 70.97% 70.97% -0.01%
+ Complexity 24583 24581 -2
============================================
Files 2690 2690
Lines 104871 104871
Branches 11020 11020
============================================
- Hits 74431 74428 -3
- Misses 26401 26403 +2
- Partials 4039 4040 +1 see 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Signed-off-by: Neeharika-Sompalli <[email protected]>
e733920
Signed-off-by: Derek Riley <[email protected]>
Node: HAPI Test (Misc Records) Results109 files +4 1 errors 108 suites +3 26m 48s ⏱️ + 15m 9s For more details on these parsing errors and failures, see this check. Results for commit 715eafe. ± Comparison against base commit a61efb5. ♻️ This comment has been updated with latest results. |
Add FATAL log validation in
HgcaaLogValidator