Import public GPG key #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: marko-bekhta <[email protected]>
yrodiere
reviewed
Apr 8, 2025
| @@ -186,6 +195,7 @@ if [ -z "$IMPORTED_KEY" ]; then | |||
| echo "Failed to import GPG key" | |||
| exit 1 | |||
| fi | |||
| IMPORTED_PUBLIC_KEY="$(gpg_import "$RELEASE_GPG_PUBLIC_KEY_PATH")" | |||
There was a problem hiding this comment.
@marko-bekhta Won't this fail on any other project where the env variable is not set? If so you just broke the release process of Search/Validator/others. Fortunately not ORM/Reactive since they don't use this script AFAIK.
There was a problem hiding this comment.
Ohh, I thought I had it as "conditional" ... but in the end it turned out to be useless, so I'll revert this change with the next update. We are looking with Andrea into hibernate-models and that would require some updates to the release scripts (so will include it there) 🙈 sorry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.