Skip to content

HHH-19207 fix missing order by #9811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025
Merged

HHH-19207 fix missing order by #9811

merged 4 commits into from
Apr 16, 2025

Conversation

baranyit
Copy link
Contributor

Test cases and possible fix for https://hibernate.atlassian.net/browse/HHH-19207


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Feb 26, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@baranyit baranyit changed the title HHH-19207 HHH-19207 fix missing order by Feb 27, 2025
@beikov
Copy link
Member

beikov commented Apr 15, 2025

Please fix the codestyle issues, by running ./gradlew :hibernate-core:spotlessApply and then push again.

@beikov
Copy link
Member

beikov commented Apr 15, 2025

I'll paste the error here for your understanding:

Execution failed for task ':hibernate-core:spotlessJavaCheck'.
> The following files had format violations:
      src/test/java/org/hibernate/orm/test/entitygraph/FetchGraphCollectionOrderByAndCriteriaJoinTest.java
          @@ -1,5 +1,5 @@
           /*
70 actionable tasks: 70 executed
          -·*·SPDX-License-Identifier:·LGPL-2.1-or-later
          +·*·SPDX-License-Identifier:·Apache-2.0
           ·*·Copyright·Red·Hat·Inc.·and·Hibernate·Authors
           ·*/
           package·org.hibernate.orm.test.entitygraph;
  Run './gradlew :hibernate-core:spotlessApply' to fix these violations.

@baranyit
Copy link
Contributor Author

looks better now... ;-)

@baranyit
Copy link
Contributor Author

sorry, I didn't realized that my push was failed... it is fixed now

@beikov beikov merged commit 3e8b28c into hibernate:main Apr 16, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants