HHH-19364 changes to Specifications to support Hibernate Processor #10066
+102
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavinking
force-pushed
the
HHH-19364-changes
branch
2 times, most recently
from
2b84dd9 to
fa0c470
Compare
1. fix generic types of parameters (should be lower bounds) 2. make it work with plain-vanilla EntityManager 3. to eliminate ambiguity in overload resolution, this unfortunately required disallowing SharedSessionContract 4. make Path.fetch() use LEFT join
gavinking
force-pushed
the
HHH-19364-changes
branch
from
fa0c470 to
876018d
Compare
|
cc @sebersole |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| /** | ||
| * Finalize the building and create executable query instance. | ||
| */ | ||
| CommonQueryContract createQuery(SharedSessionContract session); | ||
| CommonQueryContract createQuery(EntityManager entityManager); |
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| @@ -101,6 +113,11 @@ | |||
| return new QuerySqmImpl<>( sqmStatement, true, null, sessionImpl ); | |||
| } | |||
|
|
|||
| @Override | |||
| public MutationQuery createQuery(EntityManager entityManager) { | |||
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
| @@ -145,6 +157,11 @@ | |||
| return new SqmSelectionQueryImpl<>( sqmStatement, true, resultType, sessionImpl ); | |||
| } | |||
|
|
|||
| @Override | |||
| public SelectionQuery<T> createQuery(EntityManager entityManager) { | |||
Check notice
Code scanning / CodeQL
Confusing overloading of methods Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EntityManagerSharedSessionContractPath.fetch()useLEFTjoin[Please describe here what your change is about]
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-19364