New action that automatically edits PR bodies adding issue links #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
reviewed
Jun 23, 2023
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
Thanks for working on this! LGTM overall, here are a few suggestions.
src/main/java/org/hibernate/infra/bot/EditPullRequestBodyAddIssueLinks.java
Show resolved
Hide resolved
src/main/java/org/hibernate/infra/bot/EditPullRequestBodyAddIssueLinks.java
Outdated
Show resolved
Hide resolved
src/main/java/org/hibernate/infra/bot/EditPullRequestBodyAddIssueLinks.java
Outdated
Show resolved
Hide resolved
src/main/java/org/hibernate/infra/bot/EditPullRequestBodyAddIssueLinks.java
Outdated
Show resolved
Hide resolved
src/main/java/org/hibernate/infra/bot/config/RepositoryConfig.java
Outdated
Show resolved
Hide resolved
yrodiere
approved these changes
Jun 23, 2023
Member
|
@mbladel Merged, thanks! The new version of the bot should get deployed in a few minutes. |
Member
|
@mbladel It's live |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new action that automatically adds links to all Jira issues mentioned in commit messages. This is an opt-in feature, enabled with a new configuration property. The links are added only if the Jira issue keys are not already found in the PR body (either as links or as key-only).
When automatic editing is enabled, the "traditional" check for Jira keys mentions in either the title or body of PRs is disabled since we're going to link them automatically.
Related to #2.