Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test rolldown-vite #673

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

test rolldown-vite #673

wants to merge 18 commits into from

Conversation

hi-ogawa
Copy link
Owner

@hi-ogawa hi-ogawa commented Jan 27, 2025 •
edited
Loading

issues

pnpm i
pnpm build
pnpm -C packages/react-server/examples/next build
  • next/og fails
    • need ROLLUP_FILE_URL_xxx
    • for now, it's fixed user land via renderChunk replacement.
    • probably we should have this compat in Rolldown or at least in Vite.
  • prerenderPlugin fails
    • due to chunking difference from rollup, virtual:react-server-build's resolveId: { id: "../rsc/index.js", external: true } needs to be adjusted?
    • this should be fixed on my side.
  • unocss packages/react-server/examples/basic
  • unocss test-vite-glob-routes
  • optimize deps esbuild options (test-pre-bundle-new-url)

todo

@hi-ogawa hi-ogawa changed the title test rolldon-vite test rolldown-vite Jan 27, 2025
@hi-ogawa hi-ogawa mentioned this pull request Jan 28, 2025
Merged
@hi-ogawa hi-ogawa mentioned this pull request Jan 28, 2025
Closed
github-merge-queue bot pushed a commit to rolldown/rolldown that referenced this pull request Jan 29, 2025
@hi-ogawa
fix: add sequential?: boolean type for rollup compat (#3442)
e9daf93 
### Description

I added a fake "deprecated" type to reduce a churn due to ecosystem
failing by ts error (see
https://github.com/vitejs/vite-ecosystem-ci/blob/rolldown-vite/README-temp.md
and also my plugin hit by this too
hi-ogawa/vite-plugins#673).

As I wrote in
#3337 (comment),
Rolldown's plugin hook always works same as rollup's `sequential: true`
and this behavior is likely good for the ecosystem since people mostly
needed `sequential: true` to avoid running `writeBundle` hooks in
parallel on rollup.

I think the test added in #1913
already verifies such sequential behavior.
@hi-ogawa hi-ogawa force-pushed the test-rolldown-vite branch 2 times, most recently from bdbc7dd to 1842054 Compare February 3, 2025 09:57
hi-ogawa added a commit that referenced this pull request Feb 4, 2025
@hi-ogawa
fix: misc fix from #673
4563301
@hi-ogawa hi-ogawa mentioned this pull request Feb 4, 2025
Merged
hi-ogawa added a commit that referenced this pull request Feb 4, 2025
@hi-ogawa
fix: misc fix from #673 (#675)
1bce798
@hi-ogawa hi-ogawa mentioned this pull request Feb 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hi-ogawa