feat(workerd): use new transport #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
hi-ogawa
commented
Oct 27, 2024
Comment on lines
+61
to
+65
| invoke: async (payload) => { | ||
| // we still need to implement fetchModule on top of service binding | ||
| // since websocket and rpc have tighter payload size limit | ||
| // (for example, rpc 1MB is not enough for large pre-bundled deps with source map) | ||
| const response = await env.__viteInvoke.fetch(requestJson(payload)); |
There was a problem hiding this comment.
I thought this is great, but it turns out we have payload size limit for rpc...
/home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/[email protected]_@[email protected]/node_modules/wrangler/wrangler-dist/cli.js:29768
throw a;
^
Error: Serialized RPC arguments or return values are limited to 1MiB, but the size of this value was: 3828118 bytes.
at Object.respond (file:///home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/vite@file+vite-6.0.0-beta.3.tgz_@[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-DBWyyc1z.js:53470:20)
at file:///home/hiroshi/code/personal/vite-environment-examples/node_modules/.pnpm/vite@file+vite-6.0.0-beta.3.tgz_@[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-DBWyyc1z.js:64571:16 {
[cause]: undefined
}
hi-ogawa
force-pushed
the
feat-workerd-transport
branch
from
2710281 to
facbb6f
Compare
hi-ogawa
force-pushed
the
feat-workerd-transport
branch
4 times, most recently
from
a80bcc9 to
2ed493c
Compare
hi-ogawa
force-pushed
the
feat-bridge-sse
branch
from
d0627d9 to
b5c4861
Compare
hi-ogawa
force-pushed
the
feat-workerd-transport
branch
from
2ed493c to
d4af07b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.