Repository navigation
fix(cli): capture names its local page server's port in the bypass entry - #7965
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
vanceingalls
approved these changes
Nov 16, 2026
vanceingalls
left a comment
Collaborator
There was a problem hiding this comment.
Approved at 715dfb6. Capture's bypass entry now comes from pageServerDirectHost like the render and Studio paths, so an origin on its scheme's default port (http://localhost) yields localhost:80 instead of a host-wide localhost bypass. The new test fails with the old .host line. Required checks 9/9.
miguel-heygen
approved these changes
Nov 16, 2026
miguel-heygen
left a comment
Collaborator
There was a problem hiding this comment.
Approved at 715dfb6. capture now builds its bypass entry with pageServerDirectHost, the same helper the engine's browser manager and the CLI's page network already use (browserManager.ts:863, pageNetwork.ts:44). So http://localhost becomes localhost:80 instead of a bare host, which Chrome reads as every port on that host. The new test pins the default-port case.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
hyperframes capturenow builds its browser's proxy-bypass entry for the local page server withpageServerDirectHost, the same helper the render and Studio paths use since #7945. The entry always names a port.Why
Capture still built the entry from
new URL(localOrigin).host. For an origin on its scheme's default port (http://localhost),hosthas no port, so the entry waslocalhostand Chrome applied it to every port on that host. Capture was the one launch site #7945 didn't switch to the helper.Related work
Refs #7945
How
A one-line swap in
packages/cli/src/capture/launchCaptureBrowser.tsto the exportedpageServerDirectHost. Other launch arguments are unchanged.Test plan
launchCaptureBrowser.test.tsadds "names a local page server's default port in its bypass entry", which expects--proxy-bypass-list=<-loopback>;localhost:80forhttp://localhost. It fails without the fix: with the oldnew URL(...).hostline restored, that test fails and the other 7 pass. With the fix, all 8 pass.oxlint, oxfmt
--check,tsc --noEmit(cli), and the comment citation and ratchet checks pass locally.— Rames Jusso (hyperframes)
🤖 Generated with Claude Code