Repository navigation
chore: release v0.9.58 - #7932
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
Edit accuracy did not run: 0 of 15 shards reported results; see the shard jobs.Nothing was compared with the base branch. |
4724a02 to
3b52ccf
Compare
3b52ccf to
5ca6c21
Compare
eddy-heygen
left a comment
There was a problem hiding this comment.
(Eddy's agent) Reviewed by Eddy's Claude agent at commit 5ca6c21 (3b52ccf read in full by the reviewer; the branch was then rebased and I re-read the PR's own diff).
Verdict: not approved (comment only, no blocker in the diff; release PR left to a human approver).
Summary. This is a release PR, not a fix for a SecOps finding: it bumps the version from 0.9.57 to 0.9.58 in 15 package.json files and 5 plugin manifests, adds releases/v0.9.58.md and rewrites the top entry of docs/changelog.mdx. Every manifest change is the single version line; no scripts, dependencies, bin, files, publishConfig, exports, lockfile, workflow, build script or source file is touched. The notes describe the security-relevant fixes in general terms only, with no secrets, internal hostnames, ticket ids, exploit steps or mention of the Nov 13-14 incident. Merging triggers the npm publish workflow, which is gated by the npm-publish environment approval.
Comment only, not approved. No blocker in the diff, but this is a release PR and I am leaving the approval to a person.
What I checked at 5ca6c21 (the reviewer read 3b52ccf in full; the branch was then rebased onto newer main and I re-read the PR's own diff): still 22 files, the only change in every package.json and plugin manifest is the version string, and the rest is releases/v0.9.58.md and docs/changelog.mdx. No lockfile, CI workflow, build script or source file is changed, and the notes contain no secret or exploit detail.
Why not approved:
- Merging this PR is itself the release trigger: the publish workflow runs when a release PR is closed against main and publishes the packages. That decision should have a human approver.
Release checksis failing on this head. Please get it green before merging.
Blockers
None.
Non-blockers
docs/changelog.mdx:12: Notes file for the never-published v0.9.57 stays in the repo while its changelog entry is replaced. The v0.9.57 entry in docs/changelog.mdx is overwritten in place by v0.9.58, but releases/v0.9.57.md remains (the PR body says this is intended). There is no v0.9.57 tag in the worktree's repository (only v0.9.55 and v0.9.56 near that range), so that file describes a release that was never tagged or published and, per the code-review pass, links a compare range ending at a tag that does not exist. Readers of the releases folder see a release that does not exist on npm. To resolve: Delete releases/v0.9.57.md or add a one-line note in it that it was superseded by v0.9.58. Not a merge blocker.releases/v0.9.58.md:16: Two CI/test-only changes are listed as user-facing Fixes and drive the headline tags. The bullets for #7929 (publish workflow retry) and #7685 (Player Safari audio check flake) sit under Fixes at releases/v0.9.58.md:16-17 and docs/changelog.mdx:25-26, and the changelog tags are Studio Server, Publish, Player. The code-review pass reports that those two commits change only the publish workflow and a player test file, so nothing in the shipped packages changed for them. I did not open those two commits myself. To resolve: Move both bullets to Internal and pick tags that reflect shipped changes (for example Studio, Producer, Media Use). Cosmetic.
Fix criteria from the finding
Open outside this PR
- Confirm from the registry that no 0.9.57 package reached npm (not queried, per instructions). The repository evidence is consistent with the claim: there is no v0.9.57 tag, and publish.yml creates the tag (line 432) before the npm publish step (line 690). If a tag was deleted after a partial publish, some @hyperframes/*@0.9.57 packages would exist without a changelog entry.
- Confirm the PR head branch is named release/v0.9.58: the publish workflow derives the version from the branch name (publish.yml:389-390), not from package.json.
- Confirm the npm-publish GitHub environment still requires maintainer approval and who the approvers are; given the incident, also consider whether NPM_TOKEN has been rotated since Nov 13-14 (the workflow uses both the token and OIDC id-token).
- Other workflows fire on the merge push to main: catalog-publish.yml (every push to main), docs.yml (docs/** changed) and the Mintlify deployment. publish-mcp-registry.yml and sync-skills-to-clawhub.yml (secret CLAWHUB_TOKEN) are path-filtered to server.json and skills/** and should not fire for this diff. I read only their triggers, not their bodies.
- The release publishes everything on main since v0.9.56 (26 commits), including the security fixes merged in #7927, #7928, #7925, #7926, #7906, #7897. Those were reviewed in their own PRs and are not part of this diff; this review does not vouch for them.
- Regenerating the notes with the changelog draft tool may trip on the untagged 'release v0.9.57' commit in the range (reported by the code-review pass, not verified by me).
CI: at 5ca6c21 Release checks is failing and Build plus three others were still pending when this was submitted. At 3b52ccf all checks passed.
How this was reviewed: a code-review pass and a security-review pass against the Mythos finding, by a reviewer agent in an isolated checkout of this commit; I then read the core of the fix and the cited lines myself. Nothing was built or run.
5ca6c21 to
7b50314
Compare
jrusso1020
left a comment
There was a problem hiding this comment.
Approve. Reviewed at 7b50314baafde1e2ab53208514a4c65fde1ed653.
- Only versions and notes.
git diff origin/main...HEAD --statcovers 22 files. Twenty of them are"version": "0.9.57"→"0.9.58"and nothing else: 15packages/*/package.jsonplus the 5 plugin/extension manifests. The other two aredocs/changelog.mdxand the newreleases/v0.9.58.md. Nothing under.github/changes, sopublish.ymland itsenvironment: npm-publishjob are untouched. Merging doesn't publish. - Versions consistent. Every published package reads 0.9.58. The one exception,
packages/sdk-playgroundat 0.6.106, is"private": trueand the same as on main. - Notes match main. All 28 commits linked in
releases/v0.9.58.mdare ancestors of this head (git merge-base --is-ancestor, 28/28). Of the commits inv0.9.56..HEAD, only the two release commits (#7921 for v0.9.57 and this one) are left out of the notes. That's expected, since v0.9.57 has no tag and never reached npm. - Notes are public-safe. No tracker IDs, internal repo names or private links; every link points to this repo. The security fixes read as plain behaviour changes with no exploit detail.
- CI: 22 pass, 6 pending, none failing.
Nits:
- The changelog entry relabels the old v0.9.57 block as v0.9.58 instead of adding a new one. That's reasonable since v0.9.57 never shipped, but
releases/v0.9.57.mdstays in the tree describing a version that was never published. - Tags read
"Engine,producer,cli"as one tag.
Need: yes, ships the publish fix and the merged fixes after v0.9.57 never published · Size: ok · Reuse: nothing to reuse (release tooling output) · Simpler: already minimal · Structure: fine (version/notes only; no split)
Risk: low — no code; publishing still goes through the npm-publish environment's required reviewers.
— Rames
7b50314 to
67b8d44
Compare
eddy-heygen
left a comment
There was a problem hiding this comment.
(Eddy's agent) Reviewed by Eddy's Claude agent at commit 67b8d44.
Verdict: not approved (comment only, no blocker in the diff; release PR left to a human approver).
Re-read after the release was re-cut on newer main. I read the whole diff at this head myself: still 22 files. In all 15 package.json files and all 5 plugin manifests the only changed line is the version string (0.9.57 to 0.9.58). The rest is releases/v0.9.58.md and the top entry of docs/changelog.mdx, which now also list #7939, #7933, #7937, #7935 and #7941. No script, dependency, bin, files, publishConfig, exports, lockfile, CI workflow, build script or source file is touched, and the notes describe the security-relevant fixes in general terms only: no secret, internal hostname, ticket id or exploit detail.
Why it is still a comment and not an approval: merging this PR is itself the release trigger. The publish workflow runs when a release PR is closed against main and publishes the packages to npm, so that decision should have a human approver. Nothing in the diff stands in the way.
CI: no check is failing at 67b8d44 (27 pass). Catalog payloads and the CodeQL analysis were still running when I looked. Release checks, which failed at the earlier head, is not failing now.
How this was reviewed: the full diff read by me at this head; an earlier head was reviewed in full by a reviewer agent. Nothing was built or run.
There was a problem hiding this comment.
Re-review of the v0.9.58 re-cut at 67b8d442, on top of main a2e7306b2. My earlier approval was at 7b50314b.
What changed since 7b50314b: same 22 files. The 20 version files still change only 0.9.57 → 0.9.58 (20 removed, 20 added, nothing else). The notes and changelog add exactly the 5 commits that merged since the old base (ead110aab): #7937, #7941, #7939 and #7935 under Fixes, and #7933 under Internal. Each linked sha is an ancestor of this head. None of those 5 commits touches .github/ or publish config. The new note lines contain no internal IDs, so they are safe to make public. The changelog tag list now reads CLI, Studio Server, Engine,producer,cli. The combined Engine,producer,cli tag from last round is still there (nit).
CI: 27 checks pass, 2 are pending and none fail.
Need ✅ (npm still serves 0.9.56) · Size ✅ (106+/24−, version and notes only) · Reuse ✅ (standard release generator output) · Simpler ✅ · Structure ✅
Risk: low. The publish workflow is unchanged, and the only new content is release notes.
Remaining nit: the stale releases/v0.9.57.md is still there, because v0.9.57 never published.
— Rames
67b8d44 to
b36a47f
Compare
jrusso1020
left a comment
There was a problem hiding this comment.
Re-review of the second v0.9.58 re-cut at b36a47f1. Its base is main 5d5e2c06; my last approval was 5919161211 at 67b8d442.
Delta since 67b8d442: the same 22 files. The 20 version files still change only 0.9.57 → 0.9.58, and no .github/ file is in this PR's diff. The notes and changelog add exactly the two commits that merged since the previous base a2e7306b2:
- #7942: check and info never probe remote media URLs.
- #7923: the ClawHub token is read from the main-only environment.
Every earlier entry is still there: #7937, #7941, #7939, #7935 and #7933 each appear once. #7923's own change (sync-skills-to-clawhub.yml plus a test) is already on main, not in this PR. The new note lines carry no internal IDs, so they are safe to publish. The changelog tags now read Skills, CLI, Studio Server.
CI: 22 pass, 7 pending, 0 failing.
Need ✅ (npm still serves 0.9.56) · Size ✅ (110+/24−, version and notes only) · Reuse ✅ · Simpler ✅ · Structure ✅
Risk: low. The publish workflow is untouched by this PR.
The nit is unchanged: releases/v0.9.57.md is stale.
— Rames
What
Releases HyperFrames v0.9.58: the version bump across the published packages and plugin manifests, and its notes in
releases/v0.9.58.mdanddocs/changelog.mdx.No visible change
Version bump and changelog only. Each change below was reviewed, and where it shows, captured, in its own pull request.
v0.9.57 never reached npm (its publish run stopped before publishing, fixed by #7929), so this release carries its changes too, and its unpublished changelog entry is removed (its notes file stays).
Notes
Released on 2026-11-16.
Studio exports a sealed preview's checked element reads and stand-ins, and renders, carve and the audio engine keep to the project's own files. This release also carries everything prepared as v0.9.57, which never reached npm.
Features
Fixes
Docs & Examples
Internal
Full changelog
v0.9.56...v0.9.58