Return empty map when builds.txt does not exist#239
Merged
Conversation
Bob.Repo.fetch_built_refs/1 raised on S3 404, which caused Bob.Job.OTPChecker to crash for any newly-added OS target (e.g. ubuntu-26.04) before it could queue the first build — a deadlock since builds.txt is only created after the first successful build. Treat a missing builds.txt as "no refs built yet" and return an empty map, matching the semantics priv/scripts/otp/otp.sh already uses on the write side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bob.Repo.fetch_built_refs/1 raised on S3 404, which caused Bob.Job.OTPChecker to crash for any newly-added OS target (e.g. ubuntu-26.04) before it could queue the first build — a deadlock since builds.txt is only created after the first successful build.
Treat a missing builds.txt as "no refs built yet" and return an empty map, matching the semantics priv/scripts/otp/otp.sh already uses on the write side.