Fix: Map.set() fn has to return Map instance in order to chain operations. #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ises-typescript into generics-many-parameters
|
Хорошее замечание. Скорее тогда нам следует возвращать свой тип из |
|
@boldurean Василий, поправите решение? Нужна какая-то помощь? |
Привет Макс! Нет, не нужна, всё никак руки не дойдут. Сделаю обязательно. |
|
Пока перенес пр в драфт, раз работа еще ведется |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per MDN: Since the set() method returns back the same Map object, you can chain the method calls
Fixed tests & teachers solution.