Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ability to set addon name #210

Merged
merged 3 commits into from
Jul 23, 2019
Merged

Ability to set addon name #210

merged 3 commits into from
Jul 23, 2019

Conversation

davidji99
Copy link
Collaborator

@davidji99 davidji99 commented Jun 27, 2019 •
edited
Loading

  • Need to update heroku-go to support passing in Name during a PATCH addon request.

Related to #209.

@davidji99 davidji99 self-assigned this Jun 27, 2019
@ghost ghost added the size/M label Jun 27, 2019
@davidji99 davidji99 force-pushed the issues/210-ability-to-set-addon-name branch from 41a0cab to 7ccd37b Compare June 27, 2019 02:54
@ghost ghost added the documentation label Jun 27, 2019
@davidji99 davidji99 changed the title Ability to set addon name WIP: Ability to set addon name Jun 27, 2019
bernerdschaefer
bernerdschaefer reviewed Jun 27, 2019
View reviewed changes
Copy link
Contributor

@bernerdschaefer bernerdschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

heroku/resource_heroku_addon.go Outdated Show resolved Hide resolved
heroku/resource_heroku_addon.go Outdated Show resolved Hide resolved
heroku/resource_heroku_addon.go Outdated Show resolved Hide resolved
@ghost ghost added size/L and removed size/M labels Jun 28, 2019
@davidji99 davidji99 force-pushed the issues/210-ability-to-set-addon-name branch from 0196768 to e7b3187 Compare June 28, 2019 06:04
@davidji99
Copy link
Collaborator Author

@bernerdschaefer reworked the validation.

@davidji99
Copy link
Collaborator Author

Once #211 is in, I will be able to continue working on this.

@mars
Copy link
Member

mars commented Jul 11, 2019

#211 merged and released in v2.0.2

@davidji99 davidji99 force-pushed the issues/210-ability-to-set-addon-name branch from e7b3187 to 32b8b7f Compare July 16, 2019 23:51
@davidji99 davidji99 changed the title WIP: Ability to set addon name Ability to set addon name Jul 16, 2019
@davidji99
Copy link
Collaborator Author

This is ready to go.

@mars
Copy link
Member

mars commented Jul 23, 2019

Hashicorp CI passed for this branch ✅

Mergin' 🤠

@mars mars merged commit 4f59dde into master Jul 23, 2019
@davidji99 davidji99 deleted the issues/210-ability-to-set-addon-name branch July 24, 2019 00:30
@davidji99 davidji99 mentioned this pull request Aug 7, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mars mars mars approved these changes

@bernerdschaefer bernerdschaefer Awaiting requested review from bernerdschaefer

Assignees

@davidji99 davidji99

Labels
documentation size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidji99 @mars @bernerdschaefer