Merge pull request #169 from shawncatz/upgrade-heroku-go

upgrade heroku-go
heroku · Jan 31, 2019 · de66ab2 · de66ab2
2 parents 740f81d + 49f8c3b
commit de66ab2
Show file tree

Hide file tree

Showing 4 changed files with 1,311 additions and 61 deletions.
diff --git a/Gopkg.lock b/Gopkg.lock
diff --git a/heroku/resource_heroku_build.go b/heroku/resource_heroku_build.go
@@ -168,15 +168,17 @@ func resourceHerokuBuildCreate(d *schema.ResourceData, meta interface{}) error {
 
 	if v, ok := d.GetOk("buildpacks"); ok {
 		var buildpacks []*struct {
-			URL *string `json:"url,omitempty" url:"url,omitempty,key"`
+			Name *string `json:"name,omitempty" url:"name,omitempty,key"` // Buildpack Registry name of the buildpack for the app
+			URL  *string `json:"url,omitempty" url:"url,omitempty,key"`   // the URL of the buildpack for the app
 		}
 		buildpacksArg := v.([]interface{})
 		for _, buildpack := range buildpacksArg {
 			b := buildpack.(string)
 			buildpacks = append(buildpacks, &struct {
-				URL *string `json:"url,omitempty" url:"url,omitempty,key"`
+				Name *string `json:"name,omitempty" url:"name,omitempty,key"` // Buildpack Registry name of the buildpack for the app
+				URL  *string `json:"url,omitempty" url:"url,omitempty,key"`   // the URL of the buildpack for the app
 			}{
-				URL: &b,
+				URL: &b, // This may cause problems using Buildpack Registry values, may need to expand this.
 			})
 		}
 		opts.Buildpacks = buildpacks