changes from code review

heroku · Mar 1, 2021 · ba4cc44 · ba4cc44
1 parent febf992
commit ba4cc44
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 13 deletions.
diff --git a/heroku/provider_test.go b/heroku/provider_test.go
@@ -31,10 +31,6 @@ func TestProvider(t *testing.T) {
 	}
 }
 
-func TestProvider_impl(t *testing.T) {
-	var _ *schema.Provider = Provider()
-}
-
 func TestProviderConfigureUsesHeadersForClient(t *testing.T) {
 	p := Provider()
 	d := schema.TestResourceDataRaw(t, p.Schema, nil)

diff --git a/heroku/resource_heroku_app.go b/heroku/resource_heroku_app.go
@@ -344,15 +344,15 @@ func setTeamDetails(d *schema.ResourceData, app *application) (err error) {
 }
 
 func setAppDetails(d *schema.ResourceData, app *application) (err error) {
-	d.Set("name", app.App.Name)
-	d.Set("stack", app.App.Stack)
-	d.Set("internal_routing", app.App.InternalRouting)
-	d.Set("region", app.App.Region)
-	d.Set("git_url", app.App.GitURL)
-	d.Set("web_url", app.App.WebURL)
-	d.Set("acm", app.App.Acm)
-	d.Set("uuid", app.App.ID)
-	d.Set("heroku_hostname", fmt.Sprintf("%s.herokuapp.com", app.App.Name))
+	err = d.Set("name", app.App.Name)
+	err = d.Set("stack", app.App.Stack)
+	err = d.Set("internal_routing", app.App.InternalRouting)
+	err = d.Set("region", app.App.Region)
+	err = d.Set("git_url", app.App.GitURL)
+	err = d.Set("web_url", app.App.WebURL)
+	err = d.Set("acm", app.App.Acm)
+	err = d.Set("uuid", app.App.ID)
+	err = d.Set("heroku_hostname", fmt.Sprintf("%s.herokuapp.com", app.App.Name))
 
 	return err
 }