Prevent app deletion by default

heroku · Jan 13, 2025 · 1583f7b · 1583f7b
1 parent b2913ef
commit 1583f7b
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/heroku/resource_heroku_app.go b/heroku/resource_heroku_app.go
@@ -90,6 +90,11 @@ func resourceHerokuApp() *schema.Resource {
 				ForceNew: true,
 			},
 
+			"allow_deletion": {
+				Type:     schema.TypeBool,
+				Optional: true,
+			},
+
 			"buildpacks": {
 				Type:     schema.TypeList,
 				Optional: true,
@@ -562,8 +567,13 @@ func resourceHerokuAppUpdate(d *schema.ResourceData, meta interface{}) error {
 
 func resourceHerokuAppDelete(d *schema.ResourceData, meta interface{}) error {
 	client := meta.(*Config).Api
-
 	log.Printf("[INFO] Deleting App: %s", d.Id())
+
+	canBeDeleted := d.Get("allow_deletion").(bool)
+	if !canBeDeleted {
+		return fmt.Errorf("error deleting App: %s", "allow_deletion is false")
+	}
+
 	_, err := client.AppDelete(context.TODO(), d.Id())
 	if err != nil {
 		return fmt.Errorf("error deleting App: %s", err)

diff --git a/heroku/resource_heroku_app_test.go b/heroku/resource_heroku_app_test.go
@@ -763,6 +763,7 @@ func testAccCheckHerokuAppConfig_basic(appName string) string {
 resource "heroku_app" "foobar" {
   name   = "%s"
   region = "us"
+	allow_deletion = true
 
   config_vars = {
     FOO = "bar"
@@ -981,6 +982,7 @@ func testAccCheckHerokuAppConfig_locked(appName, org, locked string) string {
 resource "heroku_app" "foobar" {
   name   = "%s"
   region = "us"
+	allow_deletion = true
 
   organization {
     name = "%s"