Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: upgrade to oclif/core #132

Merged
merged 8 commits into from
Jan 30, 2025
Merged

refactor!: upgrade to oclif/core #132

merged 8 commits into from
Jan 30, 2025

Conversation

eablack
Copy link
Contributor

@eablack eablack commented Jan 23, 2025

GUS WI

Description

  • Migrates from pre-oclif/core to oclif/core 2
  • Fixes /bin/run to work with oclif/core
  • Resolves many eslint errors, add linting to ci
  • Updates http-call package, resolving a known bug
  • Updates misc packages to more recent versions, some of which should resolve security vulnerabilities
  • Update .tool-versions to node 20
  • Resolves a bug preventing manifest:diff from working properly

Testing

  1. Pull down this branch and yarn build
  2. Run ./bin/run addons:admin:manifest:pull ADDON_NAME (i used our staging scheduler addon)
  3. See that it creates a local manifest file with the right contents
  4. Run ./bin/run addons:admin:open
  5. See that it opens the addon in the partner portal based on data in the manifest just created
  6. Make a minor edit to the addon-manifest.json file
  7. Run ./bin/run addons:admin:manifest:diff and see the diffed output
  8. Run ./bin/run addons:admin:generate and follow the prompts with fake data
  9. See that it creates a local manifest file with the right contents
  10. Test 1 or 2 more random commands
  • note: be very careful if you test with destructive commands if you test them. addons:admin:manifests:push for instance will update the remote manifest. please don't do that for any of our production addons.

@eablack eablack changed the title Upgrade to oclif/core refactor!: upgrade to oclif/core Jan 23, 2025
@eablack eablack marked this pull request as ready for review January 23, 2025 23:57
@eablack eablack requested a review from a team as a code owner January 23, 2025 23:57
@eablack eablack merged commit 4a77a70 into main Jan 30, 2025
7 checks passed
@eablack eablack deleted the eb/upgrade-to-oclif-core branch January 30, 2025 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants