Skip to content

switch to intel syntax for assembly code #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 20, 2021
Merged

Conversation

stlankes
Copy link
Contributor

global_asm switch per default to the intel syntax, because the behaviour is than similiar to inline assembly. libhermit-rs follow this step and switch to the same default syntax.

See also rust-lang/rust#84107

stlankes added 2 commits May 19, 2021 23:46
global_asm switch per default to the intel syntax, because the
behaviour is similiar to inline assembly.
libhermit follow this step and switch to the same default syntax.
@stlankes
Copy link
Contributor Author

This PR is only valid, if we also change the rust toolchain is rusty-hermit

Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@stlankes stlankes merged commit b02a7ab into hermit-os:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants