DS-1351: Ensure Job#validateStep() will never take longer than 10 seconds #1554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roegi
commented
Jun 11, 2025
roegi
commented
- Add method to Async util that supports specifying a timeout
- Switch implementation of Async tool to use standard ExecutorServices instead of the shared vertx WorkerExecutor
- Add test to verify that the new Async#run() method with timeout is working properly
- Increase the number of async workers for the Job class
- Switch implementation of Async tool to use standard ExecutorServices instead of the shared vertx WorkerExecutor - Add test to verify that the new Async#run() method with timeout is working properly Signed-off-by: Benjamin Rögner <[email protected]>
…onds - Add a timeout to the async call Signed-off-by: Benjamin Rögner <[email protected]>
Signed-off-by: Benjamin Rögner <[email protected]>
roegi
force-pushed
the
jobValidationTimeout
branch
from
26588b6 to
b93c72d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.