Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update structure #404

Merged
merged 2 commits into from
Jul 3, 2023
Merged

docs: update structure #404

merged 2 commits into from
Jul 3, 2023

Conversation

woile
Copy link
Contributor

@woile woile commented Jul 2, 2023

related #388

@@ -1,5 +1,5 @@

# `system`
# Cross-platform: `system`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to reserve "cross" for cross-compilation if possible. What do you think of

Suggested change
# Cross-platform: `system`
# Multi-platform: `system`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, I think just the system may not be enough for people to know why they need it. Multi-platform is much better actually

@@ -1,17 +1,18 @@
# Summary

- [Introduction](./README.md)
- [Getting Started](./getting-started.md)
- [Cheat Sheet](./cheat-sheet.md)
- [Tutorials]()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These aren't really tutorials yet, but that's perhaps a separate issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, indeed, they need some work. I put them there because they should help a beginner achieve basic competence, whether they are doing that now is another story

@roberth
Copy link
Member

roberth commented Jul 3, 2023

bors try

bors bot added a commit that referenced this pull request Jul 3, 2023
@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@roberth
Copy link
Member

roberth commented Jul 3, 2023

bors try

Let's test the redirects

bors bot added a commit that referenced this pull request Jul 3, 2023
@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@roberth
Copy link
Member

roberth commented Jul 3, 2023

bors try

Redirect worked. Now testing the typo.

bors bot added a commit that referenced this pull request Jul 3, 2023
@roberth
Copy link
Member

roberth commented Jul 3, 2023

@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@roberth
Copy link
Member

roberth commented Jul 3, 2023

All good now. Thanks!

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 3, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 7e1629c into hercules-ci:main Jul 3, 2023
@woile
Copy link
Contributor Author

woile commented Jul 3, 2023

Do you happen to know a better link checker that supports fragments?

I would keep an eye on this issue: lycheeverse/lychee#185

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants