Add instructions on how to run #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable support to subdomains
Stop container if nginx stops
fix typo breaking sed in example
Update docker-compose.yml
If `nginx` starts up incorrectly, we'll end up waiting a week for it to start up. Instead, fail out first.
It appears that `jobs` won't track the nginx processes started from a config reload, so let's use `ps` instead. Also, set `reuseport` on all listen interfaces in order to dodge kernels that don't like `nginx` restarting quickly.
(doc) precision regarding ENVSUBST_VARS
added extra domains supported.
Without this change, you get errors from certbot asking (interactively) if you want to replace/expand the certificate Manually fixing this involve deleting all the files for the domain in question and rerunning which is way more destructive
Edit the container path for the `certbot_extra_domains` volume, to match the path in `scripts/utils.sh`.
Correct volume path for extra domains
Allow expanding certs via extra_domains_conf
Fix nginx-template readme
This setup handles multiple vhosts with the same domain being processed multiple times during the "run_certbot" flow by finding all of them, sorting them, and taking only unique values for processing. In my setup with more than 20 vhosts that have subdomains of a single root domain (and maintained via extra_domains configuration, this significantly limits the number of API hits to ACME, and prevents getting blocked when misconfigured
Someone had a problem because they named their config file `.conf` which does NOT match the `*.conf` shell glob so it wasn't loaded.
"And a `.conf` in that directory" is misleading
Update README.md
Update parse_domains parsing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please add step by step insttructions in a README.md file to get this going, so far its been a no go.