Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parallel option from make #368

Merged
merged 1 commit into from
May 29, 2024
Merged

Remove parallel option from make #368

merged 1 commit into from
May 29, 2024

Conversation

hendricius
Copy link
Owner

This temporarily removes the parallel option from make to ensure that we can release the booklet. I am not sure why it causes an issue. Baking the book without it causes no problem.

I also recommend that we use the bake option for the testing workflow in the future. This increases build time but makes sure we don't merge something that might now work.

This temporarily removes the parallel option from make to ensure that we
can release the booklet. I am not sure why it causes an issue. Baking
the book without it causes no problem.
@hendricius hendricius requested a review from cedounet May 29, 2024 07:02
@hendricius hendricius merged commit 3d16d58 into main May 29, 2024
2 checks passed
@hendricius hendricius deleted the fix-build-booklet branch May 29, 2024 07:02
cedounet added a commit that referenced this pull request May 29, 2024
This reverts commit 3d16d58.

There is no reason for parallel build to fail
cedounet added a commit that referenced this pull request May 29, 2024
Fair enough it breaks on CI... does work on my machine though :(
not sure what is going on.

This reverts commit ee5e47d.
@cedounet
Copy link
Collaborator

Makes little sense..

Both the booklet build is unstable and luatex needs to run more than 5 times. This is extremely weird as we have no bibliography, and very little label/ref if any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants