-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Booklet #362
Merged
Merged
Booklet #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is really WIP but add support in the makefile for building another book from the same source. As the target name suggests, it will be a TL;DR version of the framework.
In order to reuse recipes in the booklet, we need to extract them in their own tex file sourced by both.
Very very WIP, ugly as but need to start somewhere.
- Add pics - Change layout
- Add help target - Follow naming conventions for target
Takes less place, looks better, only good things...
Much nicer and add rooms for comments
It will also be part of the release
not perfect but better, will avoid rebuild every tiem we work on the text itself :)
cedounet
commented
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking like my fingers are consistent :). there is another typo I just spotted… you ok with me merging after fixing it or you have more ?
personally I am code complete…
thanks
👍
…On Tue 28. May 2024 at 20:12, cedounet ***@***.***> wrote:
***@***.**** commented on this pull request.
Looking like my fingers are constant :). there is another typo I just
spotted… you ok with me merging after fixing it or you have more ?
personally I am code complete…
thanks
—
Reply to this email directly, view it on GitHub
<#362 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGHNW6V2AE6IVVMSLKBY73ZETCG7AVCNFSM6AAAAABIFSSM3OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAOBTGU2TSNBZGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
LGTM - thanks for all the work. I'll make sure to upload the links so that the direct download works! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short version you would print yourself and not be worried about when using on the kitchen