#308 — Build docker image for both amd64 and arm64 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sha1sum is that meant to run for that long? |
|
@cedounet it will build twice, but no, it shouldn't take that long. Do you have the permissions to re-run it? |
I killed it and ran it again... let's see. |
|
Killed it again… I let you latest running we will see what happens. Thanks. |
hendricius
approved these changes
Dec 18, 2023
|
LGTM - thank you. I will merge for now - curious to see how long the build will take. |
hendricius
added a commit
that referenced
this pull request
Dec 18, 2023
hendricius
added a commit
that referenced
this pull request
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds the Docker image in both
arm64andamd64architectures, which will add the ability for Mac M1/M2/M3 users to run the container without emulation.Fixes #308