Small changes to Docker command and .gitignore
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please check why CI failed. thanks. |
|
@cedounet I can only assume it's something to do with permissions. It's getting a 403 forbidden when trying to upload something. |
|
This is coming from my fork so I'm not sure that the Docker image will push because it's not running with the GitHub Actions token from this repo I don't think. |
|
Yeah that makes sense. I will let @hendricius to merge, but +1 from me. |
hendricius
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.DS_Storeto.gitignorefor Mac users.--rmoption flag todockercommand so that containers are removed when the process is finished rather than leaving a bunch of containers around.