Update Sourdough History #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hendricius
force-pushed
the
sourdough-history-improvements
branch
from
b8e03e8 to
de35667
Compare
This adds another timeline for the sourdough bread history, adds more information and more references.
hendricius
force-pushed
the
sourdough-history-improvements
branch
from
de35667 to
1982856
Compare
Quoting Wikipedia: https://en.wikipedia.org/wiki/Van_(Dutch) Spelling conventions Collation and capitalisation Collation and capitalisation of names differs between countries. In the Netherlands and Suriname, names starting with "van" are filed under the initial letter of the following name proper, so Johannes van der Waals is filed under "W", as: "Waals, Johannes van der" or "van der Waals, Johannes".[3] The "v" is written in lower case, except when the surname is used as standalone (when the first name or initials are omitted), in which case it is capitalised, as in "de schilder Vincent van Gogh" and "de schilder Van Gogh" ("the painter Van Gogh").[4] In compound terms like "de Van Goghtentoonstelling" ("the Van Gogh exhibition") the "v" is capitalised, unless the connection between the person and the concept is or has become very weak.[5]
|
@cedounet thanks ❤️ . What do you think of the additions here overall? |
|
On Tue, Dec 05, 2023 at 12:01:06PM +0000, Hendrik Kleinwaechter wrote:
@cedounet thanks ❤️ . What do you think of the additions here overall?
I like it... but I am somewhat OCD when math do not match :) Takes me
a while when 10 cm means either 400 years or 12 000 years to be at ease
with it.
That aside it is a nice addition to the book, makes it well rounded
between tips, context and theory.
C/
|
- Tausend separator - Negative numbers - Few typos
cedounet
requested changes
Dec 5, 2023
|
I have more changes especially on the timeline. |
|
@cedounet thanks for the suggestions and fixes! |
- narrower so it fits on page (text was leaking out), fits mostly but not schking anymore - Different colour for BC as scale is different - Broken line for discontinuity in AD
|
|
|
@cedounet looks nice. What if you were to use the same read as the background of "Historic breadmaking"? |
|
On Fri, Dec 08, 2023 at 11:43:22AM +0000, Hendrik Kleinwaechter wrote:
@cedounet looks nice. What if you were to use the same read as the
background of "Historic breadmaking"?
I found it a bit too light for text... YMMV as usual. Will fine tune
then we can discuss.
|
|
Still need to deal with 12000 BC but as is for now FYI here is the piknk version: |
Makes it neater IMHO
|
Here is the latest, I will push code. |
added 2 commits
December 8, 2023 18:19
Also re-indent text (but only new one..)
cedounet
approved these changes
Dec 9, 2023
Rational is as follow:
- We ran validate-book on each push on the PR branch anyway
- We will run release_book which is a superset of validate
* Upload artifacts on each PR * Use artifact V3
This builds a docker image for each PR and then one for the release tagged as :latest.
|
@cedounet thank you! Lovely improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another timeline for the sourdough bread history, adds more information and more references.